docs(user-feedback): Add snippet for manual injection #11502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 978 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
ryan953
approved these changes
Oct 21, 2024
ryan953
reviewed
Oct 21, 2024
Member
There was a problem hiding this comment.
We could probably copy this file for javascript.remix.mdx too
i'm not talking about flavors for Vue, Svelte, Solid right now tho.
c298lee
approved these changes
Oct 21, 2024
lizokm
approved these changes
Oct 22, 2024
| @@ -0,0 +1,12 @@ | |||
| ```javascript | |||
| const feedback = feedbackIntegration({ | |||
| // Disable injecting the default widget | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Disable injecting the default widget | |
| // Disable the injection of the default widget |
| ```jsx {tabTitle: NextJS} | ||
| function ToggleFeedbackButton() { | ||
| const [feedback, setFeedback] = useState(); | ||
| // Read `getFeedback` on the client only, to avoid hydration errors when server rendering |
Contributor
There was a problem hiding this comment.
Suggested change
| // Read `getFeedback` on the client only, to avoid hydration errors when server rendering | |
| // Read `getFeedback` on the client only, to avoid hydration errors when server is rendering |
Member
Author
There was a problem hiding this comment.
Reading this, I think it's better to call this "to avoid hydration errors during server rendering". What do you think @lizokm ?
| ```jsx {tabTitle: React} | ||
| function ToggleFeedbackButton() { | ||
| const [feedback, setFeedback] = useState(); | ||
| // Read `getFeedback` on the client only, to avoid hydration errors when server rendering |
Contributor
There was a problem hiding this comment.
Suggested change
| // Read `getFeedback` on the client only, to avoid hydration errors when server rendering | |
| // Read `getFeedback` on the client only, to avoid hydration errors when server is rendering |
s1gr1d
force-pushed
the
sig/user-feedback-code
branch
from
bd01ebb to
7a11b58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Create separate feedback code snippets for JS and React.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: